search

tigase / tigase-server

(M) Highly optimized, extremely modular and very flexible XMPP/Jabber server
https://tigase.net
GNU Affero General Public License v3.0
317 stars 106 forks source link

Fixed hashCodeForPacket for better thread distribution #bug-177 #179

Closed karapirinc closed 1 year ago

karapirinc commented 1 year ago

bug-177 To get better thread distribution, I preferred using connection information rather than static component@hostname values.

In my unit tests, I tried to cover different combinations which I collected from the server logs.

woj-tek commented 1 year ago

Hi, thank you for PR. In order for us to proceed with it, we require "Source Code Disclaimer" - if you agree with it please submit a message stating that: "You submit your source code and allow Tigase to release the code as a part of Tigase's own software package under any license, either an open source or closed source."

karapirinc commented 1 year ago

Source Code Disclaimer

I submit my source code and I allow Tigase to release the code as a part of Tigase's own software package under any license, either an open source or closed source

woj-tek commented 1 year ago

Could you fix tests when running mvn clean test?

[INFO] Running tigase.server.xmppclient.ClientConnectionManagerHashCodeTest
[ERROR] Tests run: 23, Failures: 9, Errors: 0, Skipped: 0, Time elapsed: 0.065 s <<< FAILURE! - in tigase.server.xmppclient.ClientConnectionManagerHashCodeTest
[ERROR] testParameterizedHashCodeForPacket[17: presence Type:null Expected:PACKET_FROM c2s@localhost/127.0.0.1_5222_127.0.0.1_58041 = PacketFrom:c2s@localhost/127.0.0.1_5222_127.0.0.1_58041 StanzaFrom:null PacketTo:sess-man@localhost StanzaTo:null Command:](tigase.server.xmppclient.ClientConnectionManagerHashCodeTest)  Time elapsed: 0.009 s  <<< FAILURE!
junit.framework.AssertionFailedError: expected:<959468786> but was:<-1371074513>
    at tigase.server.xmppclient.ClientConnectionManagerHashCodeTest.testParameterizedHashCodeForPacket(ClientConnectionManagerHashCodeTest.java:108)

[ERROR] testParameterizedHashCodeForPacket[21: starttls Type:null Expected:PACKET_FROM c2s@localhost/127.0.0.1_5222_127.0.0.1_58041 = PacketFrom:c2s@localhost/127.0.0.1_5222_127.0.0.1_58041 StanzaFrom:null PacketTo:sess-man@localhost StanzaTo:null Command:](tigase.server.xmppclient.ClientConnectionManagerHashCodeTest)  Time elapsed: 0.008 s  <<< FAILURE!
junit.framework.AssertionFailedError: expected:<959468786> but was:<-1371074513>
    at tigase.server.xmppclient.ClientConnectionManagerHashCodeTest.testParameterizedHashCodeForPacket(ClientConnectionManagerHashCodeTest.java:108)

[ERROR] testParameterizedHashCodeForPacket[0: iq Type:get Expected:PACKET_FROM c2s@localhost/127.0.0.1_5222_127.0.0.1_58041 = PacketFrom:c2s@localhost/127.0.0.1_5222_127.0.0.1_58041 StanzaFrom:null PacketTo:sess-man@localhost StanzaTo:3ccb918e3c85c8a3358ae2686abd3b055cda26e3@dev.me Command:null](tigase.server.xmppclient.ClientConnectionManagerHashCodeTest)  Time elapsed: 0.001 s  <<< FAILURE!
junit.framework.AssertionFailedError: expected:<959468786> but was:<-1371074513>
    at tigase.server.xmppclient.ClientConnectionManagerHashCodeTest.testParameterizedHashCodeForPacket(ClientConnectionManagerHashCodeTest.java:108)

[ERROR] testParameterizedHashCodeForPacket[19: presence Type:subscribe Expected:PACKET_FROM c2s@localhost/127.0.0.1_5222_127.0.0.1_58041 = PacketFrom:c2s@localhost/127.0.0.1_5222_127.0.0.1_58041 StanzaFrom:null PacketTo:sess-man@localhost StanzaTo:17dccb4c4ecb50f546d06137d2a2296ef009087d@dev.me Command:](tigase.server.xmppclient.ClientConnectionManagerHashCodeTest)  Time elapsed: 0.001 s  <<< FAILURE!
junit.framework.AssertionFailedError: expected:<959468786> but was:<-1371074513>
    at tigase.server.xmppclient.ClientConnectionManagerHashCodeTest.testParameterizedHashCodeForPacket(ClientConnectionManagerHashCodeTest.java:108)

[ERROR] testParameterizedHashCodeForPacket[20: presence Type:unavailable Expected:PACKET_FROM c2s@localhost/127.0.0.1_5222_127.0.0.1_58041 = PacketFrom:c2s@localhost/127.0.0.1_5222_127.0.0.1_58041 StanzaFrom:null PacketTo:sess-man@localhost StanzaTo:null Command:](tigase.server.xmppclient.ClientConnectionManagerHashCodeTest)  Time elapsed: 0 s  <<< FAILURE!
junit.framework.AssertionFailedError: expected:<959468786> but was:<-1371074513>
    at tigase.server.xmppclient.ClientConnectionManagerHashCodeTest.testParameterizedHashCodeForPacket(ClientConnectionManagerHashCodeTest.java:108)

[ERROR] testParameterizedHashCodeForPacket[8: iq Type:set Expected:PACKET_FROM c2s@localhost/127.0.0.1_5222_127.0.0.1_58041 = PacketFrom:c2s@localhost/127.0.0.1_5222_127.0.0.1_58041 StanzaFrom:null PacketTo:sess-man@localhost StanzaTo:null Command:null](tigase.server.xmppclient.ClientConnectionManagerHashCodeTest)  Time elapsed: 0.001 s  <<< FAILURE!
junit.framework.AssertionFailedError: expected:<959468786> but was:<-1371074513>
    at tigase.server.xmppclient.ClientConnectionManagerHashCodeTest.testParameterizedHashCodeForPacket(ClientConnectionManagerHashCodeTest.java:108)

[ERROR] testParameterizedHashCodeForPacket[3: iq Type:result Expected:PACKET_FROM c2s@localhost/127.0.0.1_5222_127.0.0.1_58041 = PacketFrom:c2s@localhost/127.0.0.1_5222_127.0.0.1_58041 StanzaFrom:null PacketTo:sess-man@localhost StanzaTo:null Command:null](tigase.server.xmppclient.ClientConnectionManagerHashCodeTest)  Time elapsed: 0 s  <<< FAILURE!
junit.framework.AssertionFailedError: expected:<959468786> but was:<-1371074513>
    at tigase.server.xmppclient.ClientConnectionManagerHashCodeTest.testParameterizedHashCodeForPacket(ClientConnectionManagerHashCodeTest.java:108)

[ERROR] testParameterizedHashCodeForPacket[1: iq Type:get Expected:PACKET_FROM c2s@localhost/127.0.0.1_5222_127.0.0.1_58041 = PacketFrom:c2s@localhost/127.0.0.1_5222_127.0.0.1_58041 StanzaFrom:null PacketTo:sess-man@localhost StanzaTo:null Command:null](tigase.server.xmppclient.ClientConnectionManagerHashCodeTest)  Time elapsed: 0.003 s  <<< FAILURE!
junit.framework.AssertionFailedError: expected:<959468786> but was:<-1371074513>
    at tigase.server.xmppclient.ClientConnectionManagerHashCodeTest.testParameterizedHashCodeForPacket(ClientConnectionManagerHashCodeTest.java:108)

[ERROR] testParameterizedHashCodeForPacket[16: message Type:chat Expected:PACKET_FROM c2s@localhost/127.0.0.1_5222_127.0.0.1_58041 = PacketFrom:c2s@localhost/127.0.0.1_5222_127.0.0.1_58041 StanzaFrom:null PacketTo:sess-man@localhost StanzaTo:817382cc4e5bdbbec00ffdec92ba38d04137eedb@dev.me Command:](tigase.server.xmppclient.ClientConnectionManagerHashCodeTest)  Time elapsed: 0 s  <<< FAILURE!
junit.framework.AssertionFailedError: expected:<959468786> but was:<-1371074513>
    at tigase.server.xmppclient.ClientConnectionManagerHashCodeTest.testParameterizedHashCodeForPacket(ClientConnectionManagerHashCodeTest.java:108)