search

tigeorgia / shenmartav

Website for shenmartav.ge
GNU General Public License v2.0
3 stars 9 forks source link

[CLOSED] Income on MP's pages #154

Closed GeorgeLubaretsi closed 10 years ago

GeorgeLubaretsi commented 10 years ago

Issue by maartenmarx from Monday Dec 16, 2013 at 09:42 GMT Originally opened as https://github.com/tigeorgia/myparliament.ge/issues/16

If the income of an MP equals 0, then do not show the information at all.

GeorgeLubaretsi commented 10 years ago

Comment by GeorgeLubaretsi from Friday Dec 20, 2013 at 18:34 GMT

tigeorgia/shenmartav@71cc5043bac4a6b305d93aa26c07065a3ae4d84a

Added check, but it looks like income information is missing base income for some reason (it's commented out). I'm not sure why this was done. Do you know the reason guys?

GeorgeLubaretsi commented 10 years ago

Comment by EtienneBaque from Monday Dec 23, 2013 at 06:43 GMT

I don't know why it has been commented out, on that commit: https://github.com/tigeorgia/shenmartav/blob/66d0e48d265e1934d282dbd9960c7e242436b983/apps/representative/templates/representative/income.html The commit message says "Tweaks for launch", which doesn't help me to understand why it was commented out. I'll see what I can do about this.

GeorgeLubaretsi commented 10 years ago

Comment by EtienneBaque from Tuesday Dec 24, 2013 at 13:49 GMT

Fixed

Commit log: https://github.com/tigeorgia/shenmartav/commit/4b9422726dacfeddb8251181fdb1af6903a01872