tigeorgia / shenmartav

Website for shenmartav.ge
GNU General Public License v2.0
3 stars 9 forks source link

Admin panel - draft law status input not complete #167

Open GeorgeLubaretsi opened 10 years ago

GeorgeLubaretsi commented 10 years ago

Issue by EtienneBaque from Wednesday Jan 15, 2014 at 14:14 GMT Originally opened as https://github.com/tigeorgia/myparliament.ge/issues/29


On the admin panel, click on "Draft Laws", then click on a draft law link, to access to its details.

At the bottom of this page, there is a "Draft law discussions" section. This section has a column called "Place", and it can take either the value "Committee" or "Plenary". There is a lack of information here, there should be more inputs.

What to fix:

1) Make the "Place" column a series of selectable values (radio button type). -- @EkaR: only the values "Plenary" and "Committee" apply here? 2) When a specific value is selected, a related set of selectable data is displayed in a new column (between "Place" and "Stage"), in a list. Several values in this list should be selectable. @EkaR: do you know what values we should display in these list, for each "Place" value? What would be the name of this new column?

GeorgeLubaretsi commented 10 years ago

Comment by EkaR from Thursday Jan 16, 2014 at 06:35 GMT


1) Yes, just 'Plenary' and 'Committee'. 2) That selectable data would be the list of committees (which should only appear if clicked on a 'committee'):

აგრარულ საკითხთა კომიტეტი ადამიანის უფლებათა დაცვისა და სამოქალაქო ინტეგრაციის კომიტეტი განათლების, მეცნიერების და კულტურის კომიტეტი გარემოს დაცვისა და ბუნებრივი რესურსების კომიტეტი დარგობრივი ეკონომიკისა და ეკონომიკური პოლიტიკის კომიტეტი დიასპორისა და კავკასიის საკითხთა კომიტეტი ევროპასთან ინტეგრაციის კომიტეტი თავდაცვისა და უშიშროების კომიტეტი იურიდიულ საკითხთა კომიტეტი რეგიონული პოლიტიკისა და თვითმმართველობის კომიტეტი საგარეო ურთიერთობათა კომიტეტი საპროცედურო საკითხთა და წესების კომიტეტი საფინანსო-საბიუჯეტო კომიტეტი სპორტისა და ახალგაზრდულ საქმეთა კომიტეტი ჯანმრთელობის დაცვისა და სოციალურ საკითხთა კომიტეტი

From the list, we should be able to choose one or several committees. Should I provide the English language equivalents of the committees in the same order?

Also, in this same section we need to list "1st hearing", "2nd hearing" and "3rd hearing" under stage. If it would be easier, we could merge the 'Place' and 'Stage' columns and have the following list instead of these two:

1st committee hearing 1st plenary hearing 2nd committee hearing 2nd plenary hearing 3rd committee hearing 3rd plenary hearing

It should be possible to choose any of these 6 stages more than once. And as mentioned above, in case a committee hearing is selected (any of 3), there should be a possibility to select which committee(s) discussed the law.

Also, Etienne, something I did not mention: since we decided to improve the admin panel rather than downloading/uploading the spreadsheet, a new button should also be added in this section, which would allow to choose between: 'Passed' or 'Not passed'. And the 'Status' field should also take information from this field.

GeorgeLubaretsi commented 10 years ago

Comment by EtienneBaque from Thursday Jan 16, 2014 at 07:10 GMT


Thanks Eka for all this information. Here are some comments about it:

1) Yes, if you could translate in English the Georgian list you provided, that would be great! 2) OK to add the hearing list you provided, that said, I'm not sure it would be possible to merge "Place" and "Stage". We might need to keep the integrity of the data, and not put everything under the same column. Gio and I will sketch something and will come back to you regarding this point. 3) OK to add a drop down list with values "Passed" and "Not Passed". What is the label you'd like for this list?

GeorgeLubaretsi commented 10 years ago

Comment by EtienneBaque from Thursday Jan 16, 2014 at 10:40 GMT


Added "Passed?" drop down list: Github commit https://github.com/tigeorgia/shenmartav/commit/5429f66e43e25bd6a5610bd95c8521733752e274

etiennebaque commented 10 years ago

Needs to review this one with Eka