search

tiger-seo / PhpBuiltinServer

Codeception extension for starting and stopping php built-in server
38 stars 35 forks source link

Make Router include scripts in global space #15

Closed dontcallmedom closed 9 years ago

dontcallmedom commented 9 years ago

fix #14

nikkoss commented 9 years ago

This patch should be updated a little. There is a bug when a custom router script specified in codeception.yml is ignored. The last line in the original code was "return Router::main();". Though, it should be just "include Router::main();". So the custom router script gets executed.

dontcallmedom commented 9 years ago

Sorry, I'm not sure I understand what change you're asking to bring to the patch. Could you maybe use github in-line comments to make that clearer?

bcole808 commented 9 years ago

This fix has helped me and I would love to see it merged into the project! I have been trying to serve WordPress with this extension and the namespace issue was causing problems with WordPress.