search

tiger-seo / PhpBuiltinServer

Codeception extension for starting and stopping php built-in server
38 stars 35 forks source link

Exception class was renamed in codeception 2 #28

Closed mcustiel closed 7 years ago

mcustiel commented 8 years ago

Renamed from ModuleConfig to ModuleConfigException. In Codeception 2.0.* the class is called ModuleConfig, but from 2.1 it is called ModuleConfigException. Probably three different branches of this plugin will be needed, one for Codeception 1., one for Codeception 2.0., and one for Codeception ~2.1. I think they are introducing breaking changes with minor versions, so probably a good idea is to change the codeception version from ~2.0 to ~2.0.0, and so on.

mcustiel commented 8 years ago

Made the changes, please note that removing codeception build part is causing this:

  [Codeception\Exception\ConfigurationException]  
  UnitGuy class doesn't exist in suite folder.    
  Run the 'build' command to generate it

Also it seems that there are versioning problems after composer.lock was updated.

mbrodala commented 8 years ago

@mcustiel OK that's odd. I never had to invoke the build command manually for acceptance tests, not sure if there's something different here.

tiger-seo commented 7 years ago

@mcustiel thank you, same stuff is merged and/or implemented in the master, so i'm closing this one