search

tiger-seo / PhpBuiltinServer

Codeception extension for starting and stopping php built-in server
38 stars 35 forks source link

Fix imported exceptions #33

Closed mbrodala closed 7 years ago

mbrodala commented 8 years ago

The old exception classes do not exist anymore in newer CodeCeption releases.

Fixes #31

davidjeddy commented 8 years ago

@mbrodala any chance we can get a corrected patch?

mbrodala commented 8 years ago

PhpBrowser: Guzzle is not installed. Please install guzzlehttp/guzzle with composer

This is odd since that package is installed during build... I'll drop the --prefer-lowest from my change for now, but this should be added in a separate one.

mbrodala commented 8 years ago

OK, I think this should do.

conorgahan commented 7 years ago

Hi,

Is there any chance of getting this pull request merged as the bug it fixes has me blocked on the latest version of Codeception?

Thanks!

mbrodala commented 7 years ago

@conorgahan Until then you add the following to your composer.json and require cweagans/composer-patches:

  "extra": {
    "patches": {
      "codeception/phpbuiltinserver": {
        "Fix imported exceptions": "https://github.com/mbrodala/PhpBuiltinServer/commit/3bfce63597fd5187154b0b1e7ebb9d34084a2e23.patch"
      }
    }
  }
conorgahan commented 7 years ago

@mbrodala That's great, thanks. I had actually just referenced your fork, but this is a cleaner solution in the short term.

mbrodala commented 7 years ago

@tiger-seo Thanks for merging!

mbrodala commented 7 years ago

I'll keep my branch alive for now to not break existing references.

conorgahan commented 7 years ago

@tiger-seo Thanks for that - is there a release planned or should we just work off dev-master?

@mbrodala Thanks!

tiger-seo commented 7 years ago

@conorgahan yeah, i gonna tag this ;)

mbrodala commented 7 years ago

@tiger-seo Thanks for the release. :-)

conorgahan commented 7 years ago

@tiger-seo Thanks!