search

tiger-seo / PhpBuiltinServer

Codeception extension for starting and stopping php built-in server
38 stars 35 forks source link

support codeception v4 #39

Closed jelhan closed 2 years ago

jelhan commented 4 years ago

This is a breaking change. It drops support for

Closes #38

jelhan commented 4 years ago

@tiger-seo Any chance to get this one merged?

tiger-seo commented 4 years ago

@jelhan sorry for not responding; why do u suggest to drop codeception 3.0 and bump major version of this extension ?

jelhan commented 4 years ago

@jelhan sorry for not responding; why do u suggest to drop codeception 3.0 and bump major version of this extension ?

Mostly two reasons if I recall correctly:

  1. All supported combinations should be covered by tests. The current setup does not support running the tests against multiple versions of codeception. And I was too lazy to set that up myself.
  2. Supporting multiple versions at the same time increases maintenance costs. I think in that case it's better to focus the limited resources.

But at the end of the day that decision is up to you.

gimler commented 4 years ago

@tiger-seo any update?

+1 for drop support for legacy codeception/php version

I think when someone use a old codeception version he can use a specific branch like described in the readme

airdrummingfool commented 4 years ago

It would be great to see this PR (or #43) merged, but until that happens I am using the code from this PR via a workaround in composer.json:

change the require line to:

"codeception/phpbuiltinserver": "dev-codeception-4",

add:

    "repositories": [
      {
        "type": "vcs",
        "url": "https://github.com/jelhan/PhpBuiltinServer"
      }
    ],

This overrides the PHPBuiltinServer from Packagist with @jelhan's fork, and pulls the codeception-4 branch.

Ref:

gimler commented 2 years ago

@tiger-seo any update here for support codeception v4?

Mte90 commented 2 years ago

Ping for this PR!

Mte90 commented 2 years ago

I see with php 8.1 some issues:

PHP Warning:  proc_open(): Unable to copy file descriptor 7 (for pipe) into file descriptor 1: Bad file descriptor
PHP Warning:  proc_open(): Unable to copy file descriptor 8 (for pipe) into file descriptor 1: Bad file descriptor
xepozz commented 2 years ago

any updates here?

mikk150 commented 2 years ago

any updates here?

master branch already supports codeception 4

jelhan commented 2 years ago

Already implemented with #43. Closing this one to avoid confusion.