Exceptions rework - Githubissues

batiati commented 2 years ago

Java has 3 semantics for exceptions:

Checked exceptions, that must be declared on the "throws" block and are required to be explicitly handled by the user, who must decide how to recover from.
RuntimeExceptions, that can occur somehow due to unexpected runtime values and may be caught on the site or bubbled up to the caller
Errors, that have similar semantics to "panic", and denote that there is no possible way to recover from.

This PR removes a lot of exceptions wrongly declared on the "throws" block and assures that we are following the correct semantics in exceptions we throw in our public API.

batiati commented 2 years ago

Just pinging @eatonphil from here. Thanks!

eatonphil commented 2 years ago

It doesn't seem like the tests changed too much. Are the tests not covering the failure cases?

batiati commented 2 years ago

It doesn't seem like the tests changed too much. Are the tests not covering the failure cases?

Not yet, we have only the happy path covered by tests for now.

eatonphil commented 2 years ago

Got it. Also, do you plan to add Github Actions CI steps to run automated tests/formatting?

batiati commented 2 years ago

Yes, I have created a Maven project + GHA, it's going to be the next PR.

eatonphil commented 2 years ago

Ok! Looks good for now. Looking forward to having the CI set up to run tests and formatting and whatnot.

tigerbeetle / tigerbeetle-java

Exceptions rework #2