This PR addresses two bugs in query tg_fastRP.gsql.
Parameter choose_k ineffective
Initially implemented in commit 33bde5e, the GSQL for this parameter was removed in commit 4a12d01.
This bug has been resolved by reintroducing the GSQL from commit 33bde5e.
Incorrect zero values when print_results = TRUE
This occurs because of the line s.@final_embedding_arr.clear(), which clears the accumulator values before printing.
This bug has been resolved by removing s.@final_embedding_arr.clear(). This line was likely introduced to minimize memory consumption. However, its impact is likely minimal as it occurs towards the end of the script.
Additional Information
Testing: The changes have been tested locally.
Impact on Existing Features: No impact on existing features or new dependencies introduced.
Feedback Request
Open for feedback regarding the removal of s.@final_embedding_arr.clear() and its potential impact on memory consumption.
PR Summary
This PR addresses two bugs in query
tg_fastRP.gsql
.choose_k
ineffectiveprint_results = TRUE
s.@final_embedding_arr.clear()
, which clears the accumulator values before printing.s.@final_embedding_arr.clear()
. This line was likely introduced to minimize memory consumption. However, its impact is likely minimal as it occurs towards the end of the script.Additional Information
Feedback Request