Degree cent - Githubissues

tigergraph / gsql-graph-algorithms

GSQL Graph Algorithms

https://docs.tigergraph.com/graph-ml/current/intro/

Apache License 2.0

192 stars 70 forks source link

Degree cent #149

Closed RobRossmiller-TG closed 5 months ago

RobRossmiller-TG commented 5 months ago

PR Summary

JIRA_TICKET
- unweighted degree centrality testing.
Most of the 186 files are just moves. I removed the gsql_algorithms_baseline path in data/baseline.
Updated degree centrality to default to the normalized answer
- Added normalize param to optionally revert to previous impl
Added baseline creation pattern via networkx

PR Checklist

[ x ] Added comments for more comprehensible code.
[ x ] Added unit and/or regression tests.
[ ] (Optional) Notified Doc/Prod team, if this PR contains any new features.

What is the behavior change?

Other information:

Related PRs:

wyattjoynertg commented 5 months ago

If we're in the process of changing this query, I do have an optimization for readability and performance. Instead of a FOREACH loop of the edge types, GSQL's outdegree function supports a set of strings as a parameter. If we want to leave this kind of cleanup for another PR, that's fine as well, since it won't affect the output of the implementation.