search

tigerting98 / pe

0 stars 0 forks source link

Add command for warehouses does not check for valid address string #1

Open tigerting98 opened 3 years ago

tigerting98 commented 3 years ago

image.png

image.png

Strings that only contained symbols (in this case colons, semicolons, plus and underscore) were accepted as valid addresses.

Should there be check to prevent such invalid addresses from being added?

nus-pe-bot commented 3 years ago

Team's Response

This issue is inherited from AB3 as seen replicated below. According to forum issue #429, this bug report is rejected since it's the same behavior as in AB3.

Address, phone and email validation have been inherited from AB3 and they are for typical use cases. Users are not restricted to certain address/phone/email to cater to wider target audience which may need to handle foreign address or phone. Unnecessary restriction may lead to it being bugged/unusable for some of our intended target audience.

image.png

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]

:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: [replace this with your explanation]