tigerting98 / pe

0 stars 0 forks source link

Sequence diagrams in the DG page 16 and 18 are hard to read #12

Open tigerting98 opened 3 years ago

tigerting98 commented 3 years ago

image.png

As seen in the screenshot attached, this sequence diagram describing how the the add command works is quite hard to read at 100% zoom (real size) in Adobe Acrobat. I have to zoom in much further in order to clearly make out the words. It might be better to omit the parts about LogicManager and ClinicParser to focus on the AddCommandParser etc.

image.png

Similarly the sequence diagram on page 18 has text that is hard to read unless I zoom it a lot more.

nus-pe-bot commented 3 years ago

Team's Response

Our team thinks that the severity should be low instead of medium. This is because the diagram does not contain any errors and is still readable if users zoom in on the diagrams. Hence, it will only cause a minor inconvenience to user, who will have to zoom in and out occasionally for some diagrams to have a closer look at the details.

Items for the Tester to Verify

:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: [replace this with your explanation]