tigerting98 / pe

0 stars 0 forks source link

Error message for absurdly large numbers is inaccurate for the 'update' feature #2

Open tigerting98 opened 3 years ago

tigerting98 commented 3 years ago

image.png

The integer that I have entered is indeed unsigned. In this case, the error message should probably indicate some sort of integer overflow instead of saying the value is not an unsigned integer.

image.png

The error message in delete gives a better explanation of the error.

Should the error message for update be changed to be more consistent?

nus-pe-bot commented 3 years ago

Team's Response

The error message for update should indeed be changed for update to be consistent with delete. However, our team thinks that this should be marked as a bug with very low severity instead of low. Firstly, it is only in extremely unusual case that a supplier or warehouse will have a product with a quantity of more than 1 million. Most importantly, the input was not accepted as a valid command input. The tester has also mentioned and agreed that the integer provided is an unsigned integer as well. Thus, a correct type of error message is thrown as well, albeit less specific to that thrown in delete.

Items for the Tester to Verify

:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.Low]

Reason for disagreement: [replace this with your explanation]