search

tigerting98 / pe

0 stars 0 forks source link

Updating warehouse does not check if name of product is only numbers #3

Open tigerting98 opened 3 years ago

tigerting98 commented 3 years ago

image.png

image.png

Should there be check so that product names which consist only of numbers are rejected as it is extremely unlikely that a product name is comprised solely of numbers?

nus-pe-bot commented 3 years ago

Team's Response

Our team wants to give users the flexibility of entering the product name. For drugs, they have an associated National Drug Code linked to it.

This can be seen in the link below for drugs in US: NDC Product Code for panadol

In addition, drugs in Singapore's database are can be coded with mostly numbers as well, as shown here: Singapore Drugs database

While the numbers may include NDC or SIN infront, a user may choose to enter just the code numbers for greater convenience. This is possible as well since managers of warehouses and suppliers would be dealing with lots of drugs or medical supplies and by entering the product names as numbers, it will help to speed up the updating process. Besides, since the code is unique to each drug (i.e. different types of panadol would have different codes, such as Panadol Cough & Cold Caplet vs Panadol Flumax Caplet), users do not have to key in the entire name of the product to differentiate them in CLI-nic and would just have to key in the official product code associated to it.

Lastly, the Name field in AB3 also allows users to enter name that is comprised solely of numbers. Since we used the same Name field in AB3 for product name, hence the same issue of allowing users to enter a name containing only numbers occurs in CLI-nic as well.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]