tigerting98 / pe

0 stars 0 forks source link

Update command does not check for empty tags #8

Open tigerting98 opened 3 years ago

tigerting98 commented 3 years ago

NOTE: Could be documentation bug too image.png

image.png

I was able to execute the command even though I did not supply any keywords for the tag token t/. It seems to clear all the tags I have put on a product.

image.png

The UG does not mention anything about the usage of empty arguments for the t/ token. If this feature was intended, the UG should include a line on how empty tag keywords simply clears the tags. If not, then should there be a check for empty keywords?

nus-pe-bot commented 3 years ago

Team's Response

Supplying an empty tag prefix is supposed to overwite the original tags with no tags and hence that is the intended outcome. Nonetheless, I will accept that it could have been stated in the user guide.

Items for the Tester to Verify

:question: Issue type

Team chose [type.DocumentationBug] Originally [type.FunctionalityBug]

Reason for disagreement: [replace this with your explanation]


:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: [replace this with your explanation]