tighten / confomo

ConFOMO is a simple tool that makes it easy to track your friends at conferences.
http://confomo.com/
74 stars 29 forks source link

Laravel 5.2 Shift #60

Closed mattstauffer closed 7 years ago

mattstauffer commented 7 years ago

This pull request includes the changes for upgrading to Laravel 5.2. Feel free to commit any additional changes to the shift-3722 branch.

Before merging, you should:

If you would like more help with your upgrade, check out the human services from Laravel Shift. And if you want to level-up your Git skills, check out Getting Git.

mattstauffer commented 7 years ago

❌ Laravel 5.2 modified the default Middleware. Since your middleware differs from the Laravel 5.1 default, you will need to compare the following middleware against the 5.2 versions and merge any changes.

mattstauffer commented 7 years ago

⚠ Laravel 5.2 adds Middleware Groups for convenience. Since this may affect your routes and controllers, Shift did not automate this upgrade. You should read about Middleware Groups to understand this change.

When you are ready to upgrade to Middleware Groups, you should:

mattstauffer commented 7 years ago

ℹ Laravel 5.2 changed the value of $redirectTo from /home to / in app/Http/Controllers/Auth/AuthController.php. Shift did not make this change since you may have customized it for your app. However, you may wish to change this if you are not using Auth or if you want to follow the latest Laravel conventions.

mattstauffer commented 7 years ago

❌ Laravel 5.2 condenses the default User model dramatically. Since your app/User.php differs from the Laravel 5.1 default, you will need to compare yours against the 5.2 version and merge any changes.

mattstauffer commented 7 years ago

ℹ Laravel 5.2 updated the database session driver. If you are using the database driver, you will need to add the user_id (nullable integer), ip_address (nullable string), and user_agent (text) columns to your session database table.

mattstauffer commented 7 years ago

⚠ Shift was unable to update phpunit.xml since yours differed from the Laravel default. You will need to compare your phpunit.xml with the Laravel 5.2 version and merge any changes.

mattstauffer commented 7 years ago

⚠ Laravel 5.2 no longer registers the Input facade by default. While the Input facade is still available, Laravel 5 prefers using the Request facade or the $request object within Controllers. Review the HTTP Requests documentation for more details.

Shift changed the following files to use the Request facade. However, you should review them to see if you can use the $request object directly.

mattstauffer commented 7 years ago

❌ Shift could not upgrade the following configuration files since they differed from the default Laravel version. You will need to compare these configuration files against the default Laravel 5.2 configuration files and merge any changes:

mattstauffer commented 7 years ago

⚠ Laravel 5.2 upgraded some of the Node package dependencies. You should to compare your package.json with the Laravel 5.2 version to update your dependencies.

mattstauffer commented 7 years ago

ℹ Laravel 5.2 no longer uses the phpspec/phpspec package. Unless you require this package for your project, you may remove it from your composer.json development dependencies.

mattstauffer commented 7 years ago

❌ PHP syntax errors were detected after running your Shift. Often these are misplaced lines due to an unexpected code format.

I found PHP syntax errors in:

imjohnbon commented 7 years ago

@mattstauffer I actually have a branch with this work done already here. My apologies for the lack of communication, I started this a few weeks ago and was planning to make a single PR with a full upgrade, but then got pulled onto client work and it slipped my mind. I'll make a PR for my version and let you decide what to do with it. (edit: the PR now exists here).

I also have a 5.3 branch, however I didn't start the extra cleanup there. I just let Shift do it's thing. I can PR that here as well if you'd like.

mattstauffer commented 7 years ago

Closing because #63