search

tighten / duster

Automatic configuration for Laravel apps to apply Tighten's standard linting & code standards.
MIT License
464 stars 13 forks source link

[3.x] Fix issue with new PHP CS Fixer #152

Closed driftingly closed 2 months ago

driftingly commented 2 months ago

This PR fixes an issue with a recent PHP CS Fixer update. I believe the issue is caused by 3.59.3.

PHP Fatal error:  Class App\Fixer\ClassNotation\CustomOrderedClassElementsFixer contains 1 abstract method and must therefore be declared abstract or implement the remaining methods (PhpCsFixer\Fixer\ConfigurableFixerInterface::getConfigurationDefinition) in /app/laravel/vendor/tightenco/duster/app/Fixer/ClassNotation/CustomOrderedClassElementsFixer.php on line 42

Fatal error: Class App\Fixer\ClassNotation\CustomOrderedClassElementsFixer contains 1 abstract method and must therefore be declared abstract or implement the remaining methods (PhpCsFixer\Fixer\ConfigurableFixerInterface::getConfigurationDefinition) in /app/laravel/vendor/tightenco/duster/app/Fixer/ClassNotation/CustomOrderedClassElementsFixer.php on line 42

Additionally, I'm including the composer dev lock file to be used within GitHub actions to fix an issue with installing the latest version of Pest. The action used to install the production dependencies then requires Pest and Larastan. This was failing with a recent release of Pest. Now, we are using the same version installed when developing.

Related: #151