search

tighten / gistlog

GistLog - simple, easy blogging based on GitHub gists
https://gistlog.co/
274 stars 45 forks source link

Allow adding comments from Gistlog (without visiting gists UI) #7

Closed mattstauffer closed 9 years ago

rtablada commented 9 years ago

Are you thinking to have some sort of medium style in-line comments?

mattstauffer commented 9 years ago

Not for now--I really just mean "Allow for the ability to add, not just view, Github's native comments directly from Gistlog."

Great question; updating title.

raine commented 9 years ago

For the time being, just a link to gist.github.com that says "Comment on GitHub" would be nice?

Great job with gistlog, by the way, the posts look amazing.

JacobBennett commented 9 years ago

hey @mattstauffer I was thinking of trying to implement this with Socialite for login to the gistlog app, then use Vue.js to build out a comment form. Thoughts before I start in on this?

mattstauffer commented 9 years ago

@JacobBennett Yah, optional Socialite login would be great. The flow of how/when/etc. for authorization is going to be interesting, so I'm very interested to see what you do for that. :)

RE: Vue... is there any reason to do it VueJS rather than just good ol' plain ol' HTML/CSS? If there's a particular user flow that you want to work on, for sure, but if it's just going to submit like any old page, it sounds like a lot of extra work for no benefit. But again, if you have a particular concept that Vue could make possible, I'm 100% for it!

JacobBennett commented 9 years ago

@mattstauffer I need to figure out the flow for the Socialite login is as well I suppose. I guess I was under the impression that in order to post comments you had to be logged in through GitHub. I'm not positive if that is the case or not.

Secondly, in regards to Vue, I have been looking for a reason to use it, and an asynchronous comment box seems like the ticket on this. Add the comment as soon as they press submit, and send the update to GitHub via ajax.

Maybe on the first pass I'll do it using straight up HTML/CSS as a MVP but would like to see it be all fancy :+1:

mattstauffer commented 9 years ago

@JacobBennett I meant optional only that I want non-logged-in-users to have a first class reading experience, so we should make the log in flow be only at comment-leaving time for now. :)

Haha, that sounds fine--my concern with Vue would be auth + CORS + GitHub being a huge pain... which means you're really going to be doing Vue -> ajax -> gist log servers -> github sdk -> github.. which is a lot. So yah.. if I were you, I'd get it working sans Vue first, then do a Vue version second. Will save you some pain IMHO :)

JacobBennett commented 9 years ago

@mattstauffer agreed about the reading experience, will look similar to how it looks for someone on a gist that isn't logged in.

image

The user would be able to read comments without being logged in, but upon wanting to comment would be prompted for authorization. Would use Socialite to create a user with a remember token and a login forever sort of deal on Gistlog, or until the token expires.

mattstauffer commented 9 years ago

Fantastic. Check out out Giscus does it; really similar flow.

On Sat, Aug 15, 2015 at 10:42 PM, Jacob Bennett notifications@github.com wrote:

@mattstauffer https://github.com/mattstauffer agreed about the reading experience, will look similar to how it looks for someone on a gist that isn't logged in.

[image: image] https://cloud.githubusercontent.com/assets/1517011/9291729/406afd3c-4396-11e5-9a26-659db5e7b57a.png

The user would be able to read comments without being logged in, but upon wanting to comment would be prompted for authorization. Would use Socialite to create a user with a remember token and a login forever sort of deal on Gistlog, or until the token expires.

— Reply to this email directly or view it on GitHub https://github.com/tightenco/gistlog/issues/7#issuecomment-131477641.

Matt Stauffer Partner + Technical Director Tighten Co. 352-682-2765

JacobBennett commented 9 years ago

@mattstauffer Got Github Auth and comments on Gists working last night. Cleaning up code and starting in on UI. Excited to add this feature!

mattstauffer commented 9 years ago

Woo! Can't wait to see it!

On Mon, Aug 17, 2015 at 9:17 AM, Jacob Bennett notifications@github.com wrote:

@mattstauffer https://github.com/mattstauffer Got Github Auth and comments on Gists working last night. Cleaning up code and starting in on UI. Excited to add this feature!

— Reply to this email directly or view it on GitHub https://github.com/tightenco/gistlog/issues/7#issuecomment-131815086.

Matt Stauffer Partner + Technical Director Tighten Co. 352-682-2765