search

tighten / novapackages

https://novapackages.com
335 stars 61 forks source link

Show abandoned tag #209

Closed RhysLees closed 2 years ago

RhysLees commented 2 years ago

This PR will show a tag on the index if the package is believed to be abandoned.

image image

Closes #63

marcusmoore commented 2 years ago

Thanks for the PR @RhysLees. I'll check it out later this week 😄

marcusmoore commented 2 years ago

(This is still on my radar)

marcusmoore commented 2 years ago

This obviously fell off of my radar...

This seems to show the possibly abandoned tag on most packages. I believe it is happening because $composer_latest and $packagistData are passed to isPossiblyAbandoned() with null and []. Copying the code that populates those variables from PackageDetailResource would probably get around that issue.

But that exposes another issue: the code that populates those variables is calling Packagist::make($package->composer_name) which calls fetchData which pings packagist. This call is cached but it looks like it is only for five seconds (which should probably be addressed). Because of this, navigating the index becomes really slow.

Overall, I think addressing the issue above should come before this work.

Thank you for the contribution but I'm going to close this for now and possible re-visit it in the future but let me know you have an idea for a quick fix.