search

tighten / novapackages

https://novapackages.com
335 stars 61 forks source link

Fix Copy to Clipboard #216

Closed RhysLees closed 2 years ago

RhysLees commented 2 years ago

Currently, it seems that the copy to clipboard is broken.

This PR Removes the Clipboard package and instead implements a more 'vanilla' approach. it has a fallback so people on older browsers can still copy.

RhysLees commented 2 years ago

@marcusmoore I've simplified and removed the fallback as it's unlikely developers will be using really outdated browsers if you want to take another look

Thanks for all of the PRs lately! 💪🏾

Not a problem :)

marcusmoore commented 2 years ago

This surprised me but it looks like Brave actually uses the fallback so the latest doesn't work for me.

@RhysLees What browser are you using? Including the fallback is probably a good bet but I want to make sure it's just not my browser and extension stack that is causing the issue.

Thanks!

RhysLees commented 2 years ago

This surprised me but it looks like Brave actually uses the fallback so the latest doesn't work for me.

@RhysLees What browser are you using? Including the fallback is probably a good bet but I want to make sure it's just not my browser and extension stack that is causing the issue.

Thanks!

I use chrome, tested on Firefox aswell. So I add back fallback then?

marcusmoore commented 2 years ago

Yes please re-add the fallback and thanks again 😄

RhysLees commented 2 years ago

Yes please re-add the fallback and thanks again 😄

No problem give me 30 min and it will be back by then 😁

RhysLees commented 2 years ago

@marcusmoore Reverted removing fallback if you want to have another look :)