tighten / onramp

Easing the onramp for new or non-PHP developers to become Laravel devs.
https://onramp.dev/
MIT License
157 stars 56 forks source link

Limit the number of skills that show on a module to a max of 5 #477

Closed tammytee closed 1 year ago

tammytee commented 1 year ago

Summary

Todo

Modules to audit

Idea

Rather than removing the extra skills, we could make it so the user sees a small + 3 more bubble or something similar that can be clicked to see the remaining skills. We may also want to consider making them smaller so they don't take up so much space?

Current Example

image
LubosGangster commented 1 year ago

Hi,

i would like to help with that issue. Can you assign it to me ?

tammytee commented 1 year ago

Hi @LubosGangster!

Thanks for your help 😄. For this issue, we'd like to limit the number of skills shown on a module by default to prevent the "Overview" and "Skills" sections from getting too big. The issue title mentions a max of five, but I think this would actually work great if it's limited to four, with the fifth badge being a button users can click to see the remaining skills.

The summary above lists all of the modules that currently have 5 or more skills.

Here are some acceptance criteria for this issue:

Example:

image

Here are additional details on how to contribute to this repo. Happy coding 😃!

LubosGangster commented 1 year ago

hi @TammyTee ,

i created PR -> https://github.com/tighten/onramp/pull/485

Can you review it ?