search

tighten / takeout

Docker-based development-only dependency manager. macOS, Linux, and WSL2-only and installs via PHP's Composer... for now.
MIT License
1.6k stars 84 forks source link

Inject dependencies into constructors #201

Closed delta1186 closed 3 years ago

delta1186 commented 3 years ago

This PR resolves issue #200

I have updated the commands to include some injected dependencies. I also removed php 7.2.5 support due to takeout being updated to use phpunit 9.5 and laravel zero 8.0 which require ph 7.3 and higher. Had to add the following to composer.json in order to get it to update in Windows. :)

"platform-check": false,
        "platform": {
            "ext-pcntl": "7.2",
            "ext-posix": "7.2"
        }

Let me know if you need me to make any changes.

delta1186 commented 3 years ago

Hey @mattstauffer got your requests. I will implement those changes first thing in the morning when I get to work. Sorry I got a little ahead of myself on some of those dependency injections. Using them in my windows menu PR. 😅

Thanks for the feedback! Feel like I'm learning a lot from contributing to the open source community. 🤙🏻

mattstauffer commented 3 years ago

Thanks so much @delta1186! :)