search

tighten / takeout

Docker-based development-only dependency manager. macOS, Linux, and WSL2-only and installs via PHP's Composer... for now.
MIT License
1.59k stars 83 forks source link

Set Minio domain to allow dns buckets #265

Closed willvincent closed 2 years ago

willvincent commented 2 years ago

Closes #264.

However, it would probably be preferable for the domain default to be null and then to not include MINIO_DOMAIN in the run template at all, it wasn't immediately clear to me how that would best be accomplished, so I instead opted for a sensible default of localhost.

mattstauffer commented 2 years ago

@willvincent Hm, I think we have another one somewhere with a conditional flag? Let me try to hunt it down

mattstauffer commented 2 years ago

https://github.com/tighten/takeout/blob/main/app/Services/Sftp.php#L66

You can see a conditional modification of the dockerRunTemplate here, in Sftp.

willvincent commented 2 years ago

Ahh sweet, I'll update accordingly, thanks

mattstauffer commented 2 years ago

Thanks @willvincent!

willvincent commented 2 years ago

My pleasure, sir.