search

tighten / takeout

Docker-based development-only dependency manager. macOS, Linux, and WSL2-only and installs via PHP's Composer... for now.
MIT License
1.59k stars 83 forks source link

PHP error in phar #296

Closed MarceauKa closed 1 year ago

MarceauKa commented 2 years ago

Hi, after removing then reinstalling takeout I got this error when I try to run takeout

Parse error: syntax error, unexpected token ")" in phar:///Users/username/.composer/vendor/tightenco/takeout/builds/takeout/vendor/symfony/finder/Finder.php on line 588

Takeout: 2.1 Composer: 2.3.5 PHP: 8.0.21

mattstauffer commented 2 years ago

Thanks! Closed in 2.1.1

subdesign commented 1 year ago

Hi, I have the same error, but I have 2.2.0 installed! PHP 8.0.19 Comp: 2.3.5

Screenshot 2022-12-02 at 11 15 47
therobfonz commented 1 year ago

Also seeing this same error on 2.3.0 and PHP 8.0.26.

Screenshot 2023-01-03 at 6 05 02 AM

tonysm commented 1 year ago

Taking a look at this...

tonysm commented 1 year ago

So, packagist says we support PHP 8.0. To do that, we need to be on that version when developing, or at least at the time we're building the phar file and also when installing the Composer dependencies. Installing the Composer dependencies from a higher PHP version may get dependencies that are not compatible with PHP 8.0.

tonysm commented 1 year ago

Just tagged a new patch release v2.3.1 with the fix for this.