Changed the MSSQL image for one that works on M1

tighten / takeout

Docker-based development-only dependency manager. macOS, Linux, and WSL2-only and installs via PHP's Composer... for now.

MIT License

1.59k stars 83 forks source link

Changed the MSSQL image for one that works on M1 #298

Closed tonysm closed 1 year ago

tonysm commented 2 years ago

Changed

Changes the MSSQL image from mssql/server to azure-sql-edge which seems to be one that works on both M1 and Intel-based machines.

Note: We have only tested that when using the new image, the container (service) is able to run on M1 machines, we didn't fully tested if this image is a full replacement of the previous one. The issue of where this change originated from mentions this article which seems to imply it's a replacement.

resolves #293

mattstauffer commented 1 year ago

@tonysm I'm sorry for taking so long. This looks good; would you mind resolving the conflicts, making sure it still works, and then you can merge this and tag a release? Thanks!

tonysm commented 1 year ago

@mattstauffer I've merged main here and resolved the conflict. Tested again and the problem described in #293 still happens in main. Tested this fix and looks like it still works!