search

tighten / takeout

Docker-based development-only dependency manager. macOS, Linux, and WSL2-only and installs via PHP's Composer... for now.
MIT License
1.59k stars 83 forks source link

ghcr.io containers #310

Closed necrogami closed 1 year ago

necrogami commented 1 year ago

Currently this only handles docker hub images, while working on a potential pr for singlestore i ran into some issues since this container is not on docker hub.

The first wall i ran into is from DockerTags.php as it assumes docker hub registry, I can add an option to the function to be able to handle ghcr.io containers however to pull the tags list from github requires a github token. Do you have any ideas on how you want this handled?

tonysm commented 1 year ago

Hey @necrogami

We have other services which use a different registry, such as MsSql or Soketi, for instance, with their own implementation of the DockerTags class. Are those useful to you?

I'm closing the issue as I think those should serve as references, but pls feel free to reopen it if you think those are not very helpful in your situation.

necrogami commented 1 year ago

Any suggestions for the tagslist class? As to get the tags list it requires a github token:

https://github.com/orgs/community/discussions/26279

tonysm commented 1 year ago

You may be able to add a GitHub Token field as a prompt. Then, you could override the service's prompts() method to pass the token to the custom DockerTags class somehow (not sure how that would work). Let me know if that doesn't work and I'll take a look at how we could change it to make it work (open to suggestions as well).