search

tighten / takeout

Docker-based development-only dependency manager. macOS, Linux, and WSL2-only and installs via PHP's Composer... for now.
MIT License
1.59k stars 83 forks source link

Add traefik service #317

Closed viicslen closed 1 year ago

viicslen commented 1 year ago

Adds traefik reverse proxy to the list of available services

mattstauffer commented 1 year ago

In one of your comments you wrote this: 

// Cannot use $_SERVER superglobal since that's empty during UnitUnishTestCase;

What do you mean by UnitUnishTestCase?

viicslen commented 1 year ago

Sorry I should have removed that, that snippet of code is from stackoverflow 😅

mattstauffer commented 1 year ago

Ha! OK, I'll remove.

mattstauffer commented 1 year ago

Extracted and re-wrote here: https://github.com/tighten/takeout/commit/6eda6b577134041657f33d7e61feaba0ceb44f14

viicslen commented 1 year ago

Extracted and re-wrote here: 6eda6b5

Yeah, that looks much better.

BTW, I'm not too sure but I think the Windows directory separator should also be included when trimming the trailing slash in the following line: https://github.com/tighten/takeout/blob/6eda6b577134041657f33d7e61feaba0ceb44f14/app/Shell/Environment.php#L77

mattstauffer commented 1 year ago

whoops, thanks! i missed that.