search

tighten / takeout

Docker-based development-only dependency manager. macOS, Linux, and WSL2-only and installs via PHP's Composer... for now.
MIT License
1.59k stars 83 forks source link

Change the terminal enable list view for the Prompts combo box #328

Open gcavanunez opened 10 months ago

gcavanunez commented 10 months ago

Highlights

Notes

Initially aimed at trying to test the output from prompts, but seems like Prompts aims at ensuring regular ways of testings commands to be how we try to assert on them. (ref)

Screens

![image](https://github.com/tighten/takeout/assets/9332696/e17f1c73-fac3-4cb7-8f14-70045c523170) ![image](https://github.com/tighten/takeout/assets/9332696/20e9bd8c-318e-4138-b8e6-d6d27405a223)

Issues/Odd behavior

### Doesn't gracefully fallback, thus breaking tests ![image](https://github.com/tighten/takeout/assets/9332696/86e87623-e1ae-483f-915a-7e069b1a3554) from this test `it_can_enable_a_service_from_menu` - https://github.com/laravel/prompts/issues/39 -> Here Jess metions ways for the fallback to take place however, can't seem to make it work - https://github.com/laravel-zero/framework/pull/482 -> It looks like laravel-zero, in version 10, gains support for prompts, which could be another alternative

gcavanunez commented 9 months ago

After upgrading to "laravel/prompts": "^0.1.13" the error with the console being prompted during tests go away

This upgrade does require "laravel-zero/framework": "^10.1.1"

mattstauffer commented 1 month ago

@gcavanunez I'm super interested in getting this merged. The install box has gotten out of hand! Do you need any help to get this moved forward?

gcavanunez commented 1 month ago

@mattstauffer 100%!! Since this guy depends on bumping up to the latest version of laravel-zero, taking a look at this PR could trickle this one out