search

tighten / takeout

Docker-based development-only dependency manager. macOS, Linux, and WSL2-only and installs via PHP's Composer... for now.
MIT License
1.59k stars 83 forks source link

use of MySql 8.2 and 8.0.35 - official mysql docker hub image #329

Closed bnaydenov closed 3 months ago

bnaydenov commented 8 months ago

Currently MySql service https://github.com/tighten/takeout/blob/main/app/Services/MySql.php uses mysql docker hub image from https://hub.docker.com/r/mysql/mysql-server/ which for the last time is upgraded more then 1 year go and does not include newly released MySql 8.2. Last version available is there is8.0.32

There is official mysql docker image location https://hub.docker.com/_/mysql which is maintained by the Docker Community and the MySQL Team and is updated regularly and having all latest version like 8.2 and 8.0.35.

My suggestion is to change MySql service https://github.com/tighten/takeout/blob/main/app/Services/MySql.php to use this official image which is updated more regularly https://hub.docker.com/_/mysql.

i will provide PR

vintagesucks commented 8 months ago

mysql:8.0.34 and newer includes support for linux/arm64, so switching to mysql:8.0 should no longer be a problem.

I updated the image inside a MySQL container created by Takeout on a M1 MacBook Air from mysql/mysql-server:8.0 to mysql:8.0 to update from 8.0.32 to 8.0.35 and everything seems to be running fine.