tigoe / SoundExamples

A collection of sound examples for Arduino
https://tigoe.github.io/SoundExamples
MIT License
53 stars 12 forks source link

Fix the ordering of bytes in pitch bend commands #1

Closed isti115 closed 3 years ago

isti115 commented 3 years ago

I found your page while looking for a description on pitch bending for MIDI while I was writing a control script for my Launchpad X to be used with Bitwig Studio, and found this article really helpful, but spent quite a while figuring out why it was working in an unexpected way. As it turns out, the order of the significance of the bytes were reversed. :upside_down_face: (References: https://www.midi.org/specifications-old/item/table-1-summary-of-midi-message and https://www.cs.cmu.edu/~music/cmsip/readings/davids-midi-spec.htm)

Thank you very much for sharing such educational content, I hope that you'll manage to merge my fix to avoid confusing others that might stumble upon this. :wink:

tigoe commented 3 years ago

Thanks!