tigrang / cakephp-datatable

JQuery DataTable plugin server-side processing component for CakePHP
47 stars 29 forks source link

Remove call-time pass-by-reference to fix fatal error in PHP 5.4 #13

Closed shama closed 11 years ago

shama commented 12 years ago

Reference signs on function calls has been deprecated in 5.4. This PR fixes this error:

2012-07-20 04:13:02 Error: Fatal Error (64): Call-time pass-by-reference has been removed in [/var/www/cake2plugins/DataTable/Controller/Component/DataTableComponent.php, line 276]
2012-07-20 04:13:02 Error: [FatalErrorException] Call-time pass-by-reference has been removed
#0 /var/www/cake/lib/Cake/Error/ErrorHandler.php(162): ErrorHandler::handleFatalError(64, 'Call-time pass-...', '/var/www/cake2p...', 276)
#1 [internal function]: ErrorHandler::handleError(64, 'Call-time pass-...', '/var/www/cake2p...', 276, Array)
#2 /var/www/cake/lib/Cake/Core/App.php(926): call_user_func('ErrorHandler::h...', 64, 'Call-time pass-...', '/var/www/cake2p...', 276, Array)
#3 /var/www/cake/lib/Cake/Core/App.php(899): App::_checkFatalError()
#4 [internal function]: App::shutdown()
#5 {main}
tigrang commented 12 years ago

Thanks :) I had this done locally, but didn't push yet. I'll pull this once I update the docs for it.

shama commented 12 years ago

Yo! Merge this or push yours. Just submodule'd this and ran into this again. shakes fist at 5.4