search

tigrawap / slit

slit - a modern PAGER for viewing logs, get more than most in less time
Other
469 stars 19 forks source link

toggling a searched highlighted line leads to strange behaviors #81

Open koreno opened 4 years ago

koreno commented 4 years ago

Steps:

  1. ~ and search-highlight some items
  2. toggle off some of the resulting highlighted lines
  3. & and perform a filter action result: the lines that were toggled off are now highlighted again.

I think mixing the manual highlights with the auto-pattern-based-highlights is leading to confusion, both for the user and for the implementation. imho the usefulness of the highlights is in the ability to manually control it, so that effect should have priority. The + already lets one force-reveal lines that were hidden by some earlier filtering, which makes the ~ somewhat redundant. hope I'm making sense.

koreno commented 4 years ago

(clarification - ~ isn't redundant, as long as it is compatible with manually toggling highlights)