tigrisdata-archive / tigris-client-ts

TypeScript client for Tigris
https://www.tigrisdata.com/docs/sdkstools/typescript/
Apache License 2.0
15 stars 10 forks source link

Arrays of objects and nested arrays only support index related tags at the parent level #289

Closed ovaistariq closed 1 year ago

ovaistariq commented 1 year ago

Arrays of objects and nested arrays only support index-related tags at the parent level.

// { "field1": { "type": "object", "properties": { "name": { "type": "string" } }, "searchIndex": true } - not supported
// { "field1": { "type": "object", "properties": { "name": { "type": "string", "searchIndex": true } } } - supported
// searchIndex, sort and facet tags cannot be defined within a nested array
// { "field1": { "type": "array", "items": { "type": "object", "properties": { "name": { "type": "string", "searchIndex": true } } } } - not supported
// { "field1": { "type": "array", "items": { "type": "object", "properties": { "name": { "type": "string" } } }, "searchIndex": true } - supported

Describe your changes

How best to test these changes

Unit tests

Issue ticket number and link

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.09 :tada:

Comparison is base (2d5b30b) 89.86% compared to head (6daddac) 89.95%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #289 +/- ## ========================================== + Coverage 89.86% 89.95% +0.09% ========================================== Files 29 29 Lines 5158 5207 +49 Branches 596 605 +9 ========================================== + Hits 4635 4684 +49 Misses 522 522 Partials 1 1 ``` | [Impacted Files](https://codecov.io/gh/tigrisdata/tigris-client-ts/pull/289?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tigrisdata) | Coverage Δ | | |---|---|---| | [src/schema/decorated-schema-processor.ts](https://codecov.io/gh/tigrisdata/tigris-client-ts/pull/289?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tigrisdata#diff-c3JjL3NjaGVtYS9kZWNvcmF0ZWQtc2NoZW1hLXByb2Nlc3Nvci50cw==) | `100.00% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tigrisdata). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tigrisdata)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 1.0.0-beta.41 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 1.0.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

reviewpad[bot] commented 1 year ago

Reviewpad Report

:bangbang: Errors