Add typescript types - Githubissues

tigt / mini-svg-data-uri

Small, efficient encoding of SVG data URIs for CSS, HTML, etc.

https://npm.runkit.com/mini-svg-data-uri

MIT License

309 stars 16 forks source link

Closed fjc0k closed 4 years ago

fjc0k commented 4 years ago

This is a great package, but the typescript types is missing. Therefore, I made this PR.

tigt commented 4 years ago

I’m not against merging this in. However, because I don’t personally use TypeScript, I may do a bad job…

Updating for new TS features/versions/etc.
Helping consumers with TS problems
I might even break the types for any future refactors or features, despite trying not to

Is that okay with you?

fjc0k commented 4 years ago

@tigt Of course, I will keep the types in sync with the usage and deal with the problems encountered by typescript users. 🤝 🤓

tigt commented 4 years ago

Sounds good to me. I added you as a collaborator to the repo — does that let you merge it in yourself?

fjc0k commented 4 years ago

@tigt thx, can you publish it to npm? 😁

tigt commented 4 years ago

Yep, as soon as I remember how. On it.

tigt commented 4 years ago

I think I did it right — let me know if 1.2.3 works for you.

fjc0k commented 4 years ago

@tigt yes, it works! 🍻