tihmstar / futurerestore

A hacked up idevicerestore wrapper, which allows specifying SEP and Baseband for restoring
GNU Lesser General Public License v3.0
854 stars 278 forks source link

Fails to build with latest libgeneral #342

Open 0x9fff00 opened 3 years ago

0x9fff00 commented 3 years ago

After this commit to libgeneral, it tries to include CUSTOM_LOGGING as a file if it's defined. It's defined to 1 in futurerestore here which causes the following error when building:

In file included from futurerestore.cpp:9:
/usr/include/libgeneral/macros.h:55:13: error: #include expects "FILENAME" or <FILENAME>
   55 | #   include CUSTOM_LOGGING
      |             ^~~~~~~~~~~~~~
marleyqp commented 3 years ago

So is there a way to 'not use' this commit? Like use the previous version? (I'm new to GitHub, i dont know if thats possible)

Merculous commented 3 years ago

Same issue here.

0x9fff00 commented 3 years ago

Here is a workaround for this: https://github.com/0x9fff00/futurerestore/commit/da06799417525d2825fc8f49e2810af303ae4a66