search

tihmstar / libpatchfinder

A arm offsetfinder. It finds offsets, patches, parses Mach-O and even supports IMG4/IMG3
GNU Lesser General Public License v2.1
144 stars 70 forks source link

vmem::vmem::memstr throws exception instead of returning 0 while finding boot-args string in ibootpatchfinder64::get_boot_arg_patch. #22

Closed TheProgramableTurtle closed 4 months ago

TheProgramableTurtle commented 4 years ago

If the default boot-args string is not found, vmem::vmem::memstr should return 0 and ibootpatchfinder64::get_boot_arg_patch should fall back to the iOS 13 default string, but instead memstr instead throws an exception

terminate called after throwing an instance of 'tihmstar::not_found'
  what():  std::exception
Aborted (core dumped)

Temporarily fixed by renaming the DEFAULT_BOOTARGS_STR macro. Also, how do you get the exceptions to have the full information (like "memstr failed to find \"%s\"")?

Cryptiiiic commented 4 months ago

this is probably fixed by now

tihmstar commented 4 months ago

this is probably fixed by now

Assuming that's right i'll just close the issue. If the problem persists, please creat a new issue