search

tihu-nlp / tihu

Persian Text-To-Speech
http://lilak-project.com/tihu_demo.php
Other
84 stars 11 forks source link

g2p-seq2seq is deprecated. #40

Open b00f opened 4 years ago

b00f commented 4 years ago

g2p-seq2seq using python 2.7 which is deprecated now. There is an open issue in g2p-seq2seq about this: https://github.com/cmusphinx/g2p-seq2seq/issues/177

Updating the g2p-seq2seq is not easy since it uses tensorflow and tensorflow is known for unsuitability and changing the codebase. I emailed Nickolay who is maintaining this project and talk about this issue. here is his response:

Hello Mostafa

Nice to meet you here. I've been following your project for quite some time actually, it is a great undertaking.

I do not have the plans to keep the project alive, you might take over it if you want. I'll just add you as developers.

As for future development, I given up on Tensorflow as industry also left it. Everyone is on Pytorch nowadays. Tensorflow really screwed it with unclear API and frequent changes which break everything. 1.10 is different from 1.12 and so on and so forth. You can also read comments here: https://news.ycombinator.com/item?id=21118018

I'm planning to move to Pytorch and use maybe fairseq or a different seq2seq framework in Pytorch, but that will take some work which I don't have time to do right now. Feel free to jump in and let me know if you have further questions.

We have two options:

mohamad-hasan-sohan-ajini commented 4 years ago

@boof

If there is any plan to move toward pytorch, I'll be in!

b00f commented 4 years ago

You can fork the g2p-seq2sea project and update the project. Here is Nikolay's email address: nshmyrev@gmail.com. @nshmyrev is maintaining the g2p-seq2seq. He knew about our project. You can directly contact him. I am sure he will help you in this matter.

mohamad-hasan-sohan-ajini commented 4 years ago

A step closer to upgrade tihu G2P...

Check this repo out and suggest any consideration I should be aware for developing tihu G2P.

regards

b00f commented 4 years ago

This is awesome. Good to hear you are working on that. Thanks

mohamad-hasan-sohan-ajini commented 4 years ago

Now, G2P supports multilingual grapheme to phoneme training. Time to fork g2p-seq2seq...

b00f commented 4 years ago

I add @ebraminio to this thread. He might be interested to help