Peer review

[VSirvio]

There were no start-up instructions in the README file and the application also seems to lack the code for starting up, so I was not able to try running the application.

Database schema (project_BGEFv4/DB_scrips/schema_postGreSql_BGEF_v4.sql):

• Do roles necessarily need their own table? Maybe you could add the boolean columns registeredUser, sellerRole, buyerRole, and adminRole directly to the User table, so the database would be simpler.
• Could data like _LastBidHeaderid and numberOfBids be calculated in real-time in the database queries with COUNT etc. instead of saving them as columns in the database?
• Maybe columns like _bidExchange1id, _bidExchange2id... in BidHeader table are not necessary, because you have the _BidHeaderid columns already in the BidExchange table?
• Each BidHeader seem to have exactly one BidContent corresponding to it, and each BidContent exactly one corresponding BidHeader, so maybe BidHeader and BidContent tables could be combined into one table?

Code (project_BGEFv4/app/services_e2e):

• Should models, routes, and HTML templates be in separate files?
• Could the add user, add gear... and edit user, edit gear... pages also have a link for returning to the previous page?
• Could the pages that list all Gear, BidGenre... maybe shorten or leave out the description fields, if they are too long, so that the view would be clearer?

[tihyyti]

Your comment were the right ones and great ! During this first delivery I was thinking those also but I was too time constrained to make changes then. I would like to implement those now to the next delivery version. Thanks a lot of your valuable comments !