Remove ignore whitespace

tiimgreen / github-cheat-sheet

A list of cool features of Git and GitHub.

http://git.io/sheet

MIT License

48.17k stars 5.28k forks source link

Remove ignore whitespace #155

Closed jfountain closed 8 years ago

jfountain commented 8 years ago

Unfortunately github seems to have discontinued the '?w=1' whitespace hiding feature. Noticed this about a week ago.

bobthecow commented 8 years ago

It still works on commit page diffs (for example, see https://github.com/dkim1116/github-cheat-sheet/commit/a0162699748806851b5a24473304b1aee161db95?w=1 from #154)

hkdobrev commented 8 years ago

I think they just didn't implement everything in the new PR commit pages. For example .diff and .patch links there are not working either, but working on the canonical commit URLs.

jfountain commented 8 years ago

Interesting that it's not consistent. I'm going to contact github support directly on this. It may have been a regression bug on the new PR pages. Or maybe the feature is going to be removed on all diff pages. Either way I'll close this for now and re-open depending on feedback from github.

jfountain commented 8 years ago

I heard back from Github on this and they turned the feature back on for pull requests. All rejoice! Thanks @rsese

tiimgreen commented 8 years ago

Awesome, thanks!