Comms-vm - Githubissues

tiiuae / ghaf

TII SSRC Secure Technologies: Ghaf Framework

https://tiiuae.github.io/ghaf/

Apache License 2.0

35 stars 56 forks source link

Comms-vm #675

Closed juliuskoskela closed 4 weeks ago

juliuskoskela commented 2 months ago

Description of changes

This PR modifies the existing element-vm into a more generic comms-vm and adds Slack to it.

Checklist for things done

[ ] Summary of the proposed changes in the PR description
[ ] More detailed description in the commit message(s)
[ ] Commits are squashed into relevant entities - avoid a lot of minimal dev time commits in the PR
[ ] Contribution guidelines followed
[ ] Ghaf documentation updated with the commit - https://tiiuae.github.io/ghaf/
[ ] PR linked to architecture documentation and requirement(s) (ticket id)
[ ] Test procedure described (or includes tests). Select one or more:
- [ ] Tested on Lenovo X1 x86_64
- [ ] Tested on Jetson Orin NX or AGX aarch64
- [ ] Tested on Polarfire riscv64
[ ] Author has run nix flake check --accept-flake-config and it passes
[ ] All automatic Github Action checks pass - see actions
[ ] Author has added reviewers and removed PR draft status

Testing

humaidq-tii commented 2 months ago

I have a local branch that already includes: Slack, Teams, Microsoft 365. All as "apps" under chromium-vm. So you sign in once via SSO and you are logged in all your accounts.

Since it is launching chromium with --app, it behaves and looks mostly just like the Electron app. I will create a draft PR soon.

juliuskoskela commented 2 months ago

I have a local branch that already includes: Slack, Teams, Microsoft 365. All as "apps" under chromium-vm. So you sign in once via SSO and you are logged in all your accounts.

Since it is launching chromium with --app, it behaves and looks mostly just like the Electron app. I will create a draft PR soon.

Sounds good! I talked with Brian and we decided we'd make this a comms-vm including Element and Slack. Feel free to propose your own changes in a separate PR or alternatively we can work with this one.

humaidq-tii commented 2 months ago

Here are my change so far: https://github.com/humaidtii/ghaf/commit/32628d0cb9a64feb2e4cb8e1390f3c2cbea705a1

My question is what if we use SSO with Slack, can it open a browser window? Teams now only supports PWA and dropped their electron version^1, MS365 is only available as PWA exclusively.

I think we can solve that by having two chromium-vms. One for browsing, other one for comms/office? The office VM would have Teams, Slack, MS 365, and whatever else that is needed -- all using the same chromium process (launched with --app). This would solve problem of SSO, also opening links in general would work. This would also allow better sharing of system resources. Also in case of Teams and MS365, you login once and it logins in both automatically.

Please feel free to take the changes from my commit and include them in your PR if it makes sense. No need to open another PR.

1: https://techcommunity.microsoft.com/t5/microsoft-teams-blog/microsoft-teams-progressive-web-app-now-available-on-linux/ba-p/3669846

humaidq-tii commented 2 months ago

Also for Element, I think this can be used as PWA: https://riot.im/app/

juliuskoskela commented 2 months ago

@humaidtii Thank you for your detailed comments! I will take them into consideration and form my opinion as I do some testing. I've been working on the Jetson side thus far so I'm not up to date on all the considerations on the apps side. Thanks for bringing them up. For now I just used the electron app package.