tiiuae / ghaf

TII SSRC Secure Technologies: Ghaf Framework
https://tiiuae.github.io/ghaf/
Apache License 2.0
35 stars 56 forks source link

x1-installer: add checks in installer script, other improvements #693

Closed humaidq-tii closed 1 month ago

humaidq-tii commented 1 month ago

The image path is now set as an environment variable, so the script derivation could be reused. Also the installer derivation is created using writeShellApplication which will test against shellcheck.

Also added message on running the installer. The installer now only shows devices and the vendor/name, and doesn't include the partitions.

The installer also has proper confirmation prompts, and also warn the user if they are trying to install Ghaf on a removable device.

Description of changes

Checklist for things done

Testing

milva-unikie commented 1 month ago

Tested on Lenovo-X1 installer (nix build github:humaidq-tii/ghaf/better-installer#lenovo-x1-carbon-gen11-debug-installer)

I was able to follow the testing steps and everything is working.