tiiuae / ghaf

TII SSRC Secure Technologies: Ghaf Framework
https://tiiuae.github.io/ghaf/
Apache License 2.0
39 stars 58 forks source link

gtklock: Fix screen goes black after wrong passwords #694

Closed vunnyso closed 3 months ago

vunnyso commented 3 months ago

Description of changes

This patch will fix SP-4849 issue.

Checklist for things done

Testing

Testing instructions in SP-4849

vunnyso commented 3 months ago

As discussed with @vadika, he suggested to merge the partial fix as of now. We can update with proper fix once its available in https://github.com/jovanlanik/gtklock/issues/101

vunnyso commented 3 months ago

Code is OK.

Tested on X1: The messages are in a box and doesn't overflow. But screen still goes black after many attempts, but the limit seems to be higher.

Thanks @humaidq-tii for testing, appreciate your help. Yes if we try too many attempts there was race case possibility before which was resulting in coredump and was fixed in gtklock repo but was not included in release. Now I have included that patch as well. I don't see any black screen on my side (Tested on X1).

johannarautanen commented 3 months ago

lenovo x1, booted ghaf from SSD memory card:

No more black screen while entering lost of wrong passwords and fingerprints.

There is no scroll bar visible for the failure-texts and cannot "close" the failure-texts, that issues will be handled in https://github.com/jovanlanik/gtklock/issues/101