tiiuae / ghaf

TII SSRC Secure Technologies: Ghaf Framework
https://tiiuae.github.io/ghaf/
Apache License 2.0
35 stars 56 forks source link

Add firewall settings to business-vm #695

Closed shamma-alblooshi1 closed 1 month ago

shamma-alblooshi1 commented 1 month ago

Description of changes

Supports the trusted browsing use case Includes a firewall support for the business vm to allow users to only browse specific sites which include: MIcrosoft365 websites and in addition to TII intranet site. Includes Microsoft365, Outlook and Teams applications that run in the business-vm.

Checklist for things done

Testing

The User should open the trusted browser application from the menu. The only sites that can be accessed are microsoft365 sites that include : outlook and teams. In addition, TII's intranet site can be accessed. If the user tries to access any other website for example : youtube or github..etc it should not allow it.

In addition, the applications Microsoft365, Outlook and Teams should also work and able to connect.

milva-unikie commented 1 month ago

Tested on Lenovo-X1 (nix build github:shamma-alblooshi1/ghaf/trusted-browser#lenovo-x1-carbon-gen11-debug, last commit 73c3943)

Found issues:

Working:

Also one question: is it intentional that for example word and powerpoint documents can not be opened from Microsoft365?

shamma-alblooshi1 commented 1 month ago

Tested on Lenovo-X1 (nix build github:shamma-alblooshi1/ghaf/trusted-browser#lenovo-x1-carbon-gen11-debug, last commit 73c3943)

Found issues:

  • I was not able to open Teams. Tried both through Teams-icon and with trusted browser. 20240724_13h57m30s_grim
  • I can not login into Microsoft365-app. In trusted browser side login to office.com with that same account works. image

Working:

  • Outlook works. Can send/receive emails and open attachments.
  • Trusted browser only allows mentioned pages.
  • Test-automation passes.

Also one question: is it intentional that for example word and powerpoint documents can not be opened from Microsoft365?

brianmcgillion commented 1 month ago
  1. Logged into outlook (no reason to select outlook, just one of the MS apps)
  2. Opened Teams (it auto logged in)
  3. Opened MS365 (needed to click login, though it used the SSO after this - so no need to reenter credentials)
  4. Opened Trusted Browser
    1. Tried to access YouTube, Github, news, google search - denied access
    2. Opened outlook - url was prompted in the location bar and SSO worked

With TII accounts it is working now.

milva-unikie commented 1 month ago

Microsoft365 login is working for me now, but Teams is still refusing to work. It does not even give an option to login, only the same error message that previously. @leivos-unikie had the same result.

When using the "normal" chromium browser in Ghaf, I am able to login to Teams with no problems.

brianmcgillion commented 1 month ago

Microsoft365 login is working for me now, but Teams is still refusing to work. It does not even give an option to login, only the same error message that previously. @leivos-unikie had the same result.

When using the "normal" chromium browser in Ghaf, I am able to login to Teams with no problems.

Can you try ctrl+shift+c in the Trusted Browser to see if it is being blocked by the firewall. It might be that the firewall rules have missed a regional setting.

dig can also help from the terminal in the business-vm to see what it is trying to resolve the URL as.

leivos-unikie commented 1 month ago

After that b90644e69cecca927efe43e2fa8a23474c690157 Teams App is now working for me.

leivos-unikie commented 1 month ago

but Teams still does not work from Microsoft 365 or from the trusted browser (microsoft365.com)

leivos-unikie commented 1 month ago

Also cannot open files in Microsoft 365 app or in trusted browser / microsoft365.com

milva-unikie commented 1 month ago

I had the same results as Samuli. Teams is now working in app and in the trusted browser when you use teams.microsoft.com. It can not be opened from microsoft365.com even though Outlook can be opened from there.

shamma-alblooshi1 commented 1 month ago

I had the same results as Samuli. Teams is now working in app and in the trusted browser when you use teams.microsoft.com. It can not be opened from microsoft365.com even though Outlook can be opened from there.

Yes i am aware of this issue, opening teams from the PWA or just using teams.microsoft.com it works , but when you open it from microsoft365 there is an issue which is because it first opens a website "aka.ms" then re-directs you to teams, i allowed the aka.ms website, and this worked for me ( but this website has a very big range of ips i hopefully included all of them) . Maybe you can try the last commit now ?

milva-unikie commented 1 month ago

Yes i am aware of this issue, opening teams from the PWA or just using teams.microsoft.com it works , but when you open it from microsoft365 there is an issue which is because it first opens a website "aka.ms" then re-directs you to teams, i allowed the aka.ms website, and this worked for me ( but this website has a very big range of ips i hopefully included all of them) . Maybe you can try the last commit now ?

It is working. Teams can be opened from both Microsoft365-app and from Microsoft365.com in trusted browser.

Everything is working now with this PR!