tiiuae / ghaf

TII SSRC Secure Technologies: Ghaf Framework
https://tiiuae.github.io/ghaf/
Apache License 2.0
39 stars 58 forks source link

Enable AppArmor #714

Open gangaram-tii opened 2 months ago

gangaram-tii commented 2 months ago

Description of changes

Checklist for things done

Testing

Verify if chromium profile is active inside chromium-vm. $> sudo aa-status

Do audio and video recording/playback, Google spread sheet editing using Chromium browser.

A brief documentation and test report are available in confluence.

https://ssrc.atlassian.net/wiki/spaces/GA/pages/1187708968/Security#1.-AppArmor%3A

gangaram-tii commented 2 months ago

The Chrome settings should also be applied to the business VM where it is also running Chrome.

Done.

gangaram-tii commented 2 months ago

Rebased to latest main.

gangaram-tii commented 2 months ago

Hey, many thanks for the PR.

It would be great to add the following information to the documentation:

* Profile creation: Base profile(s) used, adjustments and reasoning

Updated the page on Confluence.

* Test information: How did we verify the profiles functionally, and what security testing/analysis did we perform?
  E.g., do we have a list of recent chromium CVEs and a potential analysis of how the confinement measures may have mitigated the impact? This would be a great motivation for using the profiles.

We did testing to verify if the rules in profile are behaving as per our expectation. Security analysis report is available here.

* Performance impact: Thanks for the figures provided. It's however not entirely clear to me how we ended up with the conclusion.
  Can we add a final table with the testing results, with clear indicator of performance impact of the test case such as "video streaming: ~5-10% overhead during initial load, ~1% during execution, etc."
  Also, it would be helpful to describe the test methodology and tools used, so one can verify the results.

Updated the test report and created a conclusion table. Will upload scripts I used to take performance data.

Mic92 commented 1 month ago

Upstream fixes has been merged.

barnabakos commented 1 week ago

2 commits up to: b07c0cf6fc83a844fc78e3e101c7aecb467f38b9 rebased to current tip of Ghaf main without conflicts: 5d5ae6d5fcee689c6ca31488cc6ed054221eadfe

platform: Lenovo X1 Carbon; flash script; USB SSD

works:

notes:

issues: