tiiuae / ghaf

TII SSRC Secure Technologies: Ghaf Framework
https://tiiuae.github.io/ghaf/
Apache License 2.0
39 stars 58 forks source link

Fix PDF XDG handler and add a new handler for JPG and PNG images #836

Closed nesteroff closed 3 weeks ago

nesteroff commented 3 weeks ago

Description of changes

Fixes SSRCSP-5360 and SSRCSP-5310.

Checklist for things done

Instructions for Testing

Test opening PDF and image files in AppVMs, and in the GUIVM from the File Explorer.

milva-unikie commented 3 weeks ago

Tested on Lenovo-X1 (nixos-rebuild switch)

Issues:

Working:

Other notes:

nesteroff commented 3 weeks ago
  • PDF files from Slack open in comms-vm browser. They should open to zathura like they do from the other vm:s.

Good catch. Should be fixed now.

  • File manager supports preview for JPG images. It would be cool to get the same support for PNG images in some future update (if that is possible).

By default the file manager limits the size of files to show thumbnails to 2 MB. This can be change in the Edit > Preferences > Display menu.

milva-unikie commented 3 weeks ago

Tested on Lenovo-X1 (nixos-rebuild switch)

All is good now!

Working:

Notes:

By default the file manager limits the size of files to show thumbnails to 2 MB. This can be change in the Edit > Preferences > Display menu.

Thanks for correcting me. I was using too small sample size to draw conclusions :)