tiiuae / ghaf

TII SSRC Secure Technologies: Ghaf Framework
https://tiiuae.github.io/ghaf/
Apache License 2.0
39 stars 58 forks source link

EWW: Hotkey indicators and performance improvements #841

Closed kajusnau closed 3 weeks ago

kajusnau commented 3 weeks ago

Description of changes

  1. Added Hotkey Indicators:

    • Hotkey indicators are simple, non-interactive widgets designed to display changes in volume and brightness.
    • The indicators appear only on the built-in display (display:0) when volume or brightness events are detected.
    • Note that the hotkey indicators will not appear when the Quick Settings widget is open. This is by design.
  2. Volume Mute Button In Quick Settings:

    • Volume can now be muted by clicking the speaker icon in the Quick Settings widget.
  3. Volume Icon Now Accurately Displays Muted State

  4. Changed From Polling To Event Listeners:

    • Replaced some polling variables with event listeners to enhance efficiency.
    • Added the get_mut option in audio-ctrl script to retrieve the current mute status.
    • Adjusted audio-ctrl script to automatically unmute audio if a volume level change is detected. This change affects Ghaf as a whole, due to most (if not all) audio control being done through audio-ctrl.
  5. UI & Formatting Clean-up:

    • Cleaned up .yuck and .scss formatting for better readability and maintainability.
    • Removed unused widgets and styles.
    • Moved color definitions to .scss for easier theming and maintenance.

Known Issues/Limitations:

  1. Bluetooth Status Not Currently Fetched

    • More investigation needed to find a good way of listening for bluetooth events and updating status.
  2. Hotkey Indicator May Become Slow To Respond

    • Hotkey indicator may slow down and appear to "lag" when multiple brightness and volume events are triggered at the same time.

Checklist for things done

Instructions for Testing

milva-unikie commented 3 weeks ago

Tested on Lenovo-X1 (nixos-rebuid switch)