tiiuae / ghaf

TII SSRC Secure Technologies: Ghaf Framework
https://tiiuae.github.io/ghaf/
Apache License 2.0
39 stars 58 forks source link

Enable Wayland security context protocol #851

Closed nesteroff closed 1 week ago

nesteroff commented 2 weeks ago

Description of changes

This enables support for the Wayland security context protocol in Ghaf. I previously added support for it to Labwc and Waypipe and upstreamed those changes. The version of Labwc used in Ghaf already includes it. For Waypipe, I added a patch but it was merged upstream recently. The new version should be released close to the end of the year. After that we should be able to get rid of the Waypipe overlay.

The security context protocol allows window frame colors to be defined on a per-VM basis rather than by application identifier. All settings are defined on the compositor side and AppVMs cannot change them. The same application can now have different border colors when run from different VMs. For example, the trusted browser and the regular one now have different colors, even though they are both Chromium.

Also, enabling the Security Context seems to resolve the issue with window caption rendering reported in SSRCSP-5343.

Technical details:

Checklist for things done

Instructions for Testing

On Lenovo X1, make sure all apps still work fine after this change and that the window borders have the correct colors. The regular Chromium and Trusted versions should now have different colors as defined in chromium.nix and business.nix.

johannarautanen commented 1 week ago

Tested on Lenovo-X1 (flashed to the SSD) (commit: 139e527d5e8ce0fae6571bf7770cda52fbb36c2a)

Working:

Issues:

nesteroff commented 1 week ago
  • business-app border color is ok, but the header color shouldn't be neon green, not user friendly at all. Hard to read the text in header and see the "minimize-maximize-close"-option.

Thanks for testing! I updated the color to a slightly different shade. Hopefully, it looks better now. As far as I understand, Joni is working on the new colors so we might update them again later.

  • minor cosmetic thing, the text editor seem to have rounded borders, so are "holes" in corners:

I guess it has always been like that but it was overlapped by the waypipe border, which is no longer used. I made a quick workaround to disable the rounded corners. I think a better fix might be to develop a Ghaf GTK theme but this is something we can consider later on.

johannarautanen commented 1 week ago

Tested on Lenovo-X1 (flashed to the SSD)

Working:

screenshot-20241029-09-14-59