tiiuae / ghaf

TII SSRC Secure Technologies: Ghaf Framework
https://tiiuae.github.io/ghaf/
Apache License 2.0
39 stars 58 forks source link

Enable USB controller for AppVMs #860

Closed nesteroff closed 1 week ago

nesteroff commented 2 weeks ago

Description of changes

QEMU VMs require a USB controller for hotplugging to work. MicroVM.nix automatically enables the USB controller when any static USB devices are added or when graphics.enable is set to true, but this is not the case for all AppVMs. For example, after the internal USB camera passthrough to ChromiumVM was commented out, there is no USB controller present and USB camera hotplugging no longer works. This fix addresses that issue.

Fixes SSRCSP-5500.

Checklist for things done

Instructions for Testing

Connect a USB camera to Lenovo X1 and make sure it's available in Chromium.

milva-unikie commented 1 week ago

Tested with Lenovo-X1 that usb camera works again in Chromium. Thanks for the quick fix!