Closed kajusnau closed 1 week ago
Tested on Lenovo-X1 (built fresh image)
Some observations:
Some observations:
- It isn't clear what the number means, and no indication that the workspace is switched. I can imagine users accidentally switching to workspace 2, thinking that their apps closed.
- I don't see why we persist workspace after reboot/relogin? We don't preserve opened windows like on Mac either.
Description of changes
Added Workspaces Control Script:
packages/ghaf-workspace
.~/.config/labwc
;Added Workspaces Widget to Taskbar:
Configured Keybindings for Workspace Switching:
Super + [number]
— Switches to the numbered workspace.Super + Alt + Right Arrow
— Switches to the next workspace.Super + Alt + Left Arrow
— Switches to the previous workspace.Defined Workspaces in Labwc Configuration:
Other changes:
Checklist for things done
x86_64
aarch64
riscv64
make-checks
and it passesnixos-rebuild ... switch
Instructions for Testing
Try to switch workspaces using the above mentioned keybinds
Try to reboot system while on workspace id 2 to see if active workspace is remembered;
Verify two-finger vertical scrolling does not change active workspace;
[x] List all targets that this applies to: Lenovo X1
[x] Is this a new feature
nixos-rebuild ... switch
[ ] If it is an improvement how does it impact existing functionality?