desktop: add bar in targets without givc

humaidq-tii commented 1 week ago

Description of changes

This adds basic bar back on targets without givc, such as vm-debug and orin.

Note that widgets, settings and network applet are still not implemented on these systems. Only power control and date/time is available.

Checklist for things done

[x] Summary of the proposed changes in the PR description
[x] More detailed description in the commit message(s)
[x] Commits are squashed into relevant entities - avoid a lot of minimal dev time commits in the PR
[x] Contribution guidelines followed
[ ] Ghaf documentation updated with the commit - https://tiiuae.github.io/ghaf/
[ ] PR linked to architecture documentation and requirement(s) (ticket id)
[x] Test procedure described (or includes tests). Select one or more:
- [x] Tested on Lenovo X1 x86_64
- [x] Tested on VM x86_64
- [x] Tested on Jetson Orin NX or AGX aarch64
- [ ] Tested on Polarfire riscv64
[ ] Author has run make-checks and it passes
[ ] All automatic Github Action checks pass - see actions
[ ] Author has added reviewers and removed PR draft status
[ ] Change requires full re-installation
[x] Change can be updated with nixos-rebuild ... switch

Instructions for Testing

[x] List all targets that this applies to: jetson orin, vm-debug
[ ] Is this a new feature
- [x] List the test steps to verify: boot orin and vm-debug. All bar elements should be functional. There is no control centre widgets or volume/brightness pop-ups. Power control should work.
[x] If it is an improvement how does it impact existing functionality? Improves usability

humaidq-tii commented 1 week ago

Maybe this diff is clearer for review: https://github.com/tiiuae/ghaf/commit/788ce3f6eb780132cb35d9ddd187aa02e4984da6#diff-8dba792a484c73ba76c47a13d5b46d23805d664883e6ba59c9258d402d8d1602

kajusnau commented 1 week ago

Great change overall! I think the checking of givc can be slightly reduced, see my comment. In addition, should we add a check where cliArgs var is defined?

humaidq-tii commented 5 days ago

In addition, should we add a check where cliArgs var is defined?

cliArgs variable would not be used on non-givc systems, so no need to add check there.

johannarautanen commented 4 days ago

Tested with Orin NX cross compile and Orin NX native

Working:

taskbar was visible when Orin nx booted up with the external screen via HDMI was plugged in
shutdown, reboot, lock and logout worked via taskbar options.
there was date/time visible on taskbar
app menu can open via taskbar
all available ghaf apps can be launched and close
ci-test automation cases ok

Issues:

When booting the Orin NX without external screen via HDMI plugged in, taskbar is not available and then windows-button don't open the Application menu.
With ghaf-open you can open the applications. taskbar.txt
When booted the Orin NX "correctly" with external screen plugged in and after that remove and plugin the HDMI cable(for screen) again, taskbar don't come visible again. Windows-button open the Application menu. hdmi_back_again.txt
After booting(taskbar visible), when you open the Terminal-app with mouse's right key via Terminal-menu, the usb keyboard doesn't response with the Terminal-app. You need to atleast open and close the "Application"-menu from taksbar or via Windows-key, after that the usb-keyboard start to work with the "Terminal"-app, that was open via Terminal-menu button. When there is no taskbar & windows-button don't open the application menu, in that case the Terminal is responding with usb keyboard right away after ghaf booted up.

Notes: I took about 10 seconds before taskbar comes visible to ghaf backgroundpage.

johannarautanen commented 4 days ago

Tested with lenovo X1 (flashed to the SSD)

Working:

Taskbar contains the control centre widgets and volume/brightness pop-ups are available too.
Network, battery, Bluetooth.... so all the X1 taskbar settings are there on the taskbar and working.
all available ghaf apps can be launched and close
ci-test automation cases ok

No new findings.

barnabakos commented 1 day ago

1 commit: db26cbea6c61f8f31714ff070729ccccb8b46f8e rebased to current tip of Ghaf main without conflicts: 86f3105c8ad9e0617bd9a40563f6372189a63ce6

platforms: NVIDIA Jetson AGX Orin; cross-compile; flash script and NVIDIA Jetson AGX Orin; native; flash script

ci-test-automation suite: ok
starting apps: ok (with "ghaf-open" command)

works:

taskbar elements & power control widget are functional

notes:

it takes about 10 seconds for the taskbar to appear

issues:

taskbar disappears when disconnecting & reconnecting the external display; windows button opens the application menu
taskbar doesn't appear if booting with cable attached but only connecting when already booted; in this case windows button doesn't open the application menu

logout & login gets the taskbar to appear; execute from terminal:

/nix/store/ij5f3rsirhvmycmi6n9y46h3c3cff0sp-labwc-0.8.0/bin/labwc --exit &

johannarautanen commented 1 day ago

Tested with Orin AGX and Orin NX native. Commit: b0bfdfb34e5d210ff1ff7039f0125f4953e841c2

Issues:

So far once able to boot up the Orin AGX to Ghaf view, other tries failed. journal_agx.odt start_agx.odt

Orin NX i haven't boot up successfully yet: journal_nx.odt start_nx.odt

humaidq-tii commented 1 day ago

@johannarautanen Maybe the system ran out of space? Try fresh install?

johannarautanen commented 1 day ago

@johannarautanen Maybe the system ran out of space? Try fresh install?

Something that.... new start from very beginning and now the Orin NX booted up normally. So, now i can start the testing :)

johannarautanen commented 1 day ago

Tested with Orin NX native amd Orin NX crosscompile commit: b0bfdfb34e5d210ff1ff7039f0125f4953e841c2

Issues:

When booting the Orin NX without external screen via HDMI plugged in, taskbar flash after 10 seconds in the up and go away. After 20 seconds the taskbar comes back and stay there. The windows-button open the Application menu almost from the very beginning after Ghaf background is visible. taskbar_blink.txt
Same taskbar-flashing happened whe booted the Orin NX "correctly" with external screen plugged in and after that remove and plugin the HDMI cable. After 20 seconds taskbar is visible. Also in this case the windows-button open the Application menu almost from the very beginning after Ghaf background is visible.
After booting(taskbar visible), when you open the Terminal-app with mouse's right key via Terminal-menu, the usb keyboard doesn't response with the Terminal-app. You need to atleast open and close the "Application"-menu from taksbar or via Windows-key, after that the usb-keyboard start to work with the "Terminal"-app, that was open via Terminal-menu button. When there is no taskbar & windows-button don't open the application menu, in that case the Terminal is responding with usb keyboard right away after ghaf booted up.

Notes:

resume seems to work in this version, wake up with moving the mouse

Working:

taskbar is visible after 10-20 seconds.
Windows-button open the Application menu no matter how remove or attach the hdmi-cable
shutdown, reboot, lockr and logout worked via taskbar options.
there was date/time visible on taskbar
app menu can open via taskbar
all available ghaf apps can be launched and close
ci-test automation cases ok

tiiuae / ghaf